feat(FEC-12953): Add configuration option to change the default playlist image item duration #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ist image item duration
JonathanTGold
requested review from
giladna,
SivanA-Kaltura and
semarche-kaltura
5 tasks
SivanA-Kaltura
requested changes
Feb 19, 2023
SivanA-Kaltura
approved these changes
Feb 19, 2023
JonathanTGold
added a commit
to kaltura/playkit-js-image-player
that referenced
this pull request
Feb 19, 2023
…ist image item duration (#10) Currently the only way to set an image duration while playing a single media is by overriding the duration property, but this is not possible when playing playlist by entry so we need to add configuration option in loadPlaylist() public API solves FEC-12953 related pr: kaltura/kaltura-player-js#607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Currently the only way to set an image duration while playing a single media is by overriding the duration property, but this is not possible when playing playlist by entry so we need to add configuration option in loadPlaylist() public API
solves FEC-12953
related pr:
kaltura/playkit-js-image-player#10
CheckLists