Remove ResponsiveBackground component #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for responsive images in browsers is limited, you cannot have all the possibilities of the browser picking the best supported file format *and* size, as `<picture>` and `srcset` combined can do. With the `object-fit` CSS property you can still create a `<img>` that behaves like a background. For now this is left to the user to implement, as we need to concentrate on getting the next-gen version of plain images working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for responsive images in browsers is limited, you cannot have all the possibilities of the browser picking the best supported file format and size, as
<picture>andsrcsetcombined can do. With theobject-fitCSS property you can still create a<img>that behaves like a background. For now this is left to the user to implement, as we need to concentrate on getting the next-gen version of plain images working.Closes #87
/cc @andreasschacht @lolmaus