Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: set kairos testnet burnt amount correctly for totalSupply api #23

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

yoomee1313
Copy link
Contributor

Proposed changes

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the [ ] I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

Tested at private network and the burnt amount is changed like below. This is testnet so zeroed and allocated amount is not set or balance is not allocated.

> klay.getTotalSupply('latest')
{
  burntFee: "0x12ab5b35b946200",
  deadBurn: "0x0",
  error: "cannot determine rebalance (kip103, kip160) burn amount: rebalance memo not yet stored",
  kip103Burn: "0x0",
  kip160Burn: null,
  number: "0x25d",
  totalBurnt: null,
  totalMinted: "0x111b0ec57e6499a1f4b117ef38222bc7ce207903800",
  totalSupply: null,
  zeroBurn: "0x0"
}
> klay.getTotalSupply('latest')
{
  burntFee: "0x12fe5e19693ce00",
  deadBurn: "0x0",
  kip103Burn: "0x0",
  kip160Burn: "-0xbf82646906be407e42a4800",
  number: "0x282",
  totalBurnt: "-0xbf826468f3bfe264d967a00",
  totalMinted: "0x111b0ec57e6499a1f4b117ef395642062f3e2503800",
  totalSupply: "0x111b0ec57e6499a1f4b1d7719dbf35c611a2fe6b200",
  zeroBurn: "0x0"
}

@yoomee1313 yoomee1313 self-assigned this Jun 24, 2024
Copy link

github-actions bot commented Jun 24, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@yoomee1313
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@yoomee1313 yoomee1313 marked this pull request as ready for review June 26, 2024 01:55
@yoomee1313 yoomee1313 merged commit 400def5 into kaiachain:dev Jun 28, 2024
11 checks passed
@yoomee1313 yoomee1313 deleted the correct-kairos-burnt-amount branch June 28, 2024 07:03
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants