Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner error handeling? #10

Open
mabushey opened this issue Jan 5, 2023 · 0 comments
Open

Cleaner error handeling? #10

mabushey opened this issue Jan 5, 2023 · 0 comments

Comments

@mabushey
Copy link

mabushey commented Jan 5, 2023

I have a subtitle with this:

857
00:46:28,703 --> 00:46:30,288

erenotgonna supportthat

Obviously this is a problem srt. This crate gives:

thread 'main' panicked at 'parser error: Error { inner: Error { inner: ParseIntError { kind: InvalidDigit }

expected SubRip index line, found 'erenotgonna supportthat'

Which isn't horrible but seems like it could have a more graceful crash, or better yet handle the extra return. My guess is it got this way from someone editing a subtitle and removing [Ruby] (Persons name) w/o removing the return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant