-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bypass TS6133 error by allowing function declarations that are unused #323
Bypass TS6133 error by allowing function declarations that are unused #323
Conversation
package-lock.json
Outdated
"resolved": "https://registry.npmjs.org/typescript/-/typescript-2.4.2.tgz", | ||
"integrity": "sha1-+DlfhdRZJ2BnyYiqQYN6j4KHCEQ=", | ||
"version": "2.6.1", | ||
"resolved": "http://artifactory.es.ad.adp.com:8081/artifactory/api/npm/ohcm-npms/typescript/-/typescript-2.6.1.tgz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pointing to an internal registry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved. Thanks!
ae51c05
to
b2888cf
Compare
Here's a benchmark run and test suites for these changes:
|
Looks good, thank you :) |
Thanks @tjvr. What's the npm release cadence for Nearley? |
Um, whenever someone bugs me to do a release, I suppose? :) |
@tjvr I am officially bugging you to do a release 😁 |
With the release of TypeScript 2.6.1, we now have the option to suppress errors in .ts files using '// @ts-ignore' comments.
Fixes #322