Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform validation of values entered #12

Open
1 of 8 tasks
kabili207 opened this issue Jan 8, 2019 · 0 comments
Open
1 of 8 tasks

Perform validation of values entered #12

kabili207 opened this issue Jan 8, 2019 · 0 comments

Comments

@kabili207
Copy link
Owner

kabili207 commented Jan 8, 2019

There are various combinations of values that could result in unexpected behavior when a secret is used. Functions to validate a secret should be created to check for these cases.

  • Child values should be constrained to a maximum value for linked secrets. See this analysis.
  • Function should also be created to allow users to create a valid value from rules used by the game. (added with 10e1b7d)
  • The free ring given value should be checked for each secret type.
  • None should not be an allowed animal friend value when creating a secret for Seasons. (See bug Remove "None" for the animal companion #7)
  • Verify that users haven't inserted invalid values into enums
    • Animal friend
    • Memory values
  • Allow loading of rings from mismatched game IDs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant