Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] exclude range currently does not correctly handle invalid syntax #364

Closed
andreaskaris opened this issue Jul 19, 2023 · 0 comments · Fixed by #365
Closed

[BUG] exclude range currently does not correctly handle invalid syntax #364

andreaskaris opened this issue Jul 19, 2023 · 0 comments · Fixed by #365

Comments

@andreaskaris
Copy link
Contributor

andreaskaris commented Jul 19, 2023

Describe the bug
Invalid syntax in an exclude range is currently ignored, and a nil pointer is added to excludeRanges, leading to a nil pointer exception in skipExludedSubnets
This also includes cases where the excludeRange is a single IP address

Expected behavior
A clear and concise description of what you expected to happen.

To Reproduce
Steps to reproduce the behavior:

  1. See the unit tests for the submitted patch

Environment:

  • Whereabouts version : N/A
  • Kubernetes version (use kubectl version): N/A
  • Network-attachment-definition: N/A
  • Whereabouts configuration (on the host): N/A
  • OS (e.g. from /etc/os-release): N/A
  • Kernel (e.g. uname -a): N/A
  • Others: N/A

Additional info / context
Add any other information / context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant