Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Deployment of SR-IOV Network Operator via helm #56

Closed
adrianchiris opened this issue Jan 28, 2021 · 13 comments
Closed

Support Deployment of SR-IOV Network Operator via helm #56

adrianchiris opened this issue Jan 28, 2021 · 13 comments
Labels
enhancement New feature or request

Comments

@adrianchiris
Copy link
Collaborator

This Enhancement proposes to add Helm charts to the project to allow an easy depoyment of sriov-network-operator in a k8s environment.

The charts will be added in a new deployment folder under the project root.

upon release the chart parameter can be modified to point to a release version of sriov network operator images and possibly be made available in a helm repository.
one way of doing that is using github pages to host the repository (index file, packaged charts and possibly some project documentation)

However this can be regarded as a followup effort.

@adrianchiris adrianchiris added the enhancement New feature or request label Jan 28, 2021
@e0ne
Copy link
Collaborator

e0ne commented Apr 6, 2021

Helm chars is added in #76. We still need to create helm chart repository to allow people use charts from it

@adrianchiris
Copy link
Collaborator Author

Discussed the Helm Repository part of this issue in today's community meeting.

having a helm repository is desirable and github pages seems like a viable option to do it.
@martinkennelly is also +1 on it.

@zshi-redhat @pliurh do you have any inputs / preferences / objections ?

At the end the user would have to do the following to deploy sriov-network-operator:

$ helm repo sno-repo https://k8snetworkplumbingwg.github.io/sriov-network-operator
$ helm repo update
$ helm install -n sriov-network-operator --create-namespace --wait sriov-network-operator sno-repo/sriov-network-operator

An alternative could be to have a place for the entire org to host project charts (A gh_pages branch in https://github.com/k8snetworkplumbingwg/helm-charts ?)
This would need to be raised in the npwg bi-weekly meeting.

A downside for this approach is that it would not be self contained.

@pliurh
Copy link
Collaborator

pliurh commented Apr 12, 2021

An alternative could be to have a place for the entire org to host project charts (A gh_pages branch in https://github.com/k8snetworkplumbingwg/helm-charts ?)

I prefer this approach. @dougbtv What's your suggestion?

@ianb-mp
Copy link
Contributor

ianb-mp commented Apr 30, 2024

It'd be great to see a solution to this. A central repo for helm-charts sounds like the right approach, unfortunately it looks like https://github.com/k8snetworkplumbingwg/helm-charts/ has been abandoned

@SchSeba
Copy link
Collaborator

SchSeba commented Apr 30, 2024

That is fine we can push on having just a github pages to support it

@ianb-mp
Copy link
Contributor

ianb-mp commented May 8, 2024

That is fine we can push on having just a github pages to support it

@SchSeba I had a look at this. A common pattern for publishing helm charts is to use the Chart Releaser Github action to update index.yml in gh-pages branch, and push a release & chart tar file to the main/master branch. Alternatively, the chart tar can be stored in gh-pages branch. Before this can be setup, I think the release process needs to be clarified. For example, it looks like releases are currently done manually and not driven from Actions.

@SchSeba
Copy link
Collaborator

SchSeba commented May 22, 2024

Agree that are stuffs we need to talk about will it be possible for you to join our next community meeting?

https://docs.google.com/document/d/1sJQMHbxZdeYJPgAWK1aSt6yzZ4K_8es7woVIrwinVwI/edit

@ianb-mp
Copy link
Contributor

ianb-mp commented May 22, 2024

Agree that are stuffs we need to talk about will it be possible for you to join our next community meeting?

@SchSeba I would like to attend, however that meeting is at midnight in my timezone which makes it difficult for me. BTW, did you mean to post the doc edit link?

@SchSeba
Copy link
Collaborator

SchSeba commented Jun 2, 2024

sure the link is open to everyone who wants to contribute :)

I am sorry that the time zone doesn't work for you.
do you want to open a PR and we can review the PR?

@ianb-mp
Copy link
Contributor

ianb-mp commented Jun 2, 2024

do you want to open a PR and we can review the PR?

@SchSeba to be clear, the PR would be to host helm chart in sriov-network-operator repo (and not use https://github.com/k8snetworkplumbingwg/helm-charts/ repo)?

@dougbtv @e0ne do either of you have thoughts on this? If the 'helm-charts' repo is no longer to be used, it should be archived.

@SchSeba
Copy link
Collaborator

SchSeba commented Jun 3, 2024

I am fine to host the sriov-operator helm in this repo

@ianb-mp
Copy link
Contributor

ianb-mp commented Jun 18, 2024

It looks like this is fixed by #715

GHCR hosts the helm chart which can be used like this:

$ helm install -n sriov-network-operator --create-namespace \
  --version 1.3.0 \
  --set sriovOperatorConfig.deploy=true sriov-network-operator \
  oci://ghcr.io/k8snetworkplumbingwg/sriov-network-operator-chart

@SchSeba
Copy link
Collaborator

SchSeba commented Aug 19, 2024

that is right @ianb-mp
closing this issue

@SchSeba SchSeba closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants