-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize the k8s-reporter in the e2e tests #498
Utilize the k8s-reporter in the e2e tests #498
Conversation
Thanks for your PR,
To skip the vendors CIs use one of:
|
ade3a2f
to
d4b4533
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Eoghan1232 can you please take a look as we need another company maintainer to merge this PR |
Modify the k8sreporter/reporter.go to utilize the latest external k8s-reporter package. The new reporter still outputs the same output as before plus the CRDs: SriovOperatorConfig and SriovNetwork. It is used by the conformance and validation suites, consumes the flag "-report" as the path to where the dir "sriov_failure_report.log" will be created and hold all of the failed tests logs. Also removed the unused `-junit` flag, as we're using Ginkgo's built it --junit-report tool. Added the `-report` flag to the run-e2e-conformance.sh script. Signed-off-by: Lior Noy <[email protected]>
d4b4533
to
992723c
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 6160735016
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! much cleaner way to do it!
Modify the k8sreporter/reporter.go to utilize
the latest external k8s-reporter package.
The new reporter still outputs the same output as before plus the CRDs: SriovOperatorConfig and SriovNetwork.
It is used by the conformance and validation suites, consumes the flag "-report" as the path to where the dir "sriov_failure_report.log" will be created and hold all of the failed tests logs.
Here is an example of the k8s reporter tree output when all the tests of the validation suite failed:
Where the crs.log will dump all of the CRDs,
nodes.log is the list of nodes objects in json format,
and in case pods exist in the sriov namespace, it will dump
for each test: pods_logs.log and pods_specs.log
For more details about the reporter see here: https://github.com/openshift-kni/k8sreporter