Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize the k8s-reporter in the e2e tests #498

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

liornoy
Copy link
Contributor

@liornoy liornoy commented Sep 5, 2023

Modify the k8sreporter/reporter.go to utilize
the latest external k8s-reporter package.

The new reporter still outputs the same output as before plus the CRDs: SriovOperatorConfig and SriovNetwork.

It is used by the conformance and validation suites, consumes the flag "-report" as the path to where the dir "sriov_failure_report.log" will be created and hold all of the failed tests logs.

Here is an example of the k8s reporter tree output when all the tests of the validation suite failed:

.
└── sriov_failure_report.log
    ├── validation_sriov_should_deploy_the_injector_pod_if_requested
    │   ├── crs.log
    │   └── nodes.log
    ├── validation_sriov_should_deploy_the_operator_webhook_if_requested
    │   ├── crs.log
    │   └── nodes.log
    ├── validation_sriov_should_have_SR-IOV_node_statuses_not_in_progress
    │   ├── crs.log
    │   └── nodes.log
    ├── validation_sriov_Should_have_the_sriov_CRDs_available_in_the_cluster
    │   ├── crs.log
    │   └── nodes.log
    ├── validation_sriov_should_have_the_sriov_namespace
    │   ├── crs.log
    │   └── nodes.log
    └── validation_sriov_should_have_the_sriov_operator_deployment_in_running_state
        ├── crs.log
        └── nodes.log

Where the crs.log will dump all of the CRDs,
nodes.log is the list of nodes objects in json format,
and in case pods exist in the sriov namespace, it will dump
for each test: pods_logs.log and pods_specs.log

For more details about the reporter see here: https://github.com/openshift-kni/k8sreporter

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@liornoy liornoy force-pushed the update-k8s-reporter branch from ade3a2f to d4b4533 Compare September 6, 2023 09:36
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchSeba
Copy link
Collaborator

SchSeba commented Sep 12, 2023

@Eoghan1232 can you please take a look as we need another company maintainer to merge this PR

Modify the k8sreporter/reporter.go to utilize
the latest external k8s-reporter package.

The new reporter still outputs the same output as before
plus the CRDs: SriovOperatorConfig and SriovNetwork.

It is used by the conformance and validation suites,
consumes the flag "-report" as the path to where the dir
"sriov_failure_report.log" will be created and hold all of
the failed tests logs.
Also removed the unused `-junit` flag, as we're using Ginkgo's
built it --junit-report tool.

Added the `-report` flag to the run-e2e-conformance.sh script.

Signed-off-by: Lior Noy <[email protected]>
@liornoy liornoy force-pushed the update-k8s-reporter branch from d4b4533 to 992723c Compare September 12, 2023 14:16
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6160735016

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 25.488%

Files with Coverage Reduction New Missed Lines %
controllers/sriovnetworkpoolconfig_controller.go 4 53.03%
Totals Coverage Status
Change from base Build 6145086661: 0.04%
Covered Lines: 2129
Relevant Lines: 8353

💛 - Coveralls

Copy link
Collaborator

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! much cleaner way to do it!

@Eoghan1232 Eoghan1232 merged commit 0a6cacd into k8snetworkplumbingwg:master Sep 13, 2023
9 checks passed
@liornoy liornoy deleted the update-k8s-reporter branch September 13, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants