Fix Plugin Config Daemon node selector #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
/cc @SchSeba |
Pull Request Test Coverage Report for Build 5733255954
💛 - Coveralls |
SchSeba
reviewed
Aug 6, 2023
When node selectors are added via "configDaemonNodeSelector"
via the sriovoperatorconfigs CRD then completely removed, the previous
node selectors would remain for the plugin config daemons
(sriov-device-plugin). This was not cleaned up, because the function
"syncPluginDaemonSet" bails out when "configDaemonNodeSelector" is
empty. For example:
Step 1) Create 3 labels in node selector:
configDaemonNodeSelector = {"labelA": "", "labelB": "", "labelC": ""}
device-plugin DS NodeSelector = {"labelA": "", "labelB": "", "labelC": ""}
Step 2) Remove all labels in node selector:
configDaemonNodeSelector = {}
device-plugin DS NodeSelector = {"labelA": "", "labelB": "", "labelC": ""}
The expectation is that the device plugin will revert to the default
node selectors (e.g. {"node-role.kubernetes.io/worker": "",
"kubernetes.io/os": "linux"})
This change will make the node selector field in the sriov-device-plugin
to take in a variable. This default node selector value is then shared
with the code that updates the node selector.
Signed-off-by: William Zhao <[email protected]>
wizhaoredhat
force-pushed
the
fix_plugin_ds_node_selector
branch
from
ad92936 to
48b2aeb
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
reviewed
Aug 30, 2023
|
@adrianchiris @e0ne Please take a look when you have a chance. Thanks! |
|
Hey, A question: What is the behaviour today when first deploying sriov-network-operator with sriovoperatorconfig having an empty ConfigDaemonNodeSelector? as far as i see from the codebase. it will not deploy daemonsets. is my understanding correct ? |
|
Hi @adrianchiris, |
|
@adrianchiris @SchSeba Yes by default the node selector is on Is this good on your end. Could we merge this changes? |
e0ne
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When node selectors are added via "configDaemonNodeSelector" via the sriovoperatorconfigs CRD then completely removed, the previous node selectors would remain for the plugin config daemons (sriov-device-plugin). This was not cleaned up, because the function "syncPluginDaemonSet" bails out when "configDaemonNodeSelector" is empty. For example:
The expectation is that the device plugin will revert to the default node selectors (e.g. {"node-role.kubernetes.io/worker": "", "kubernetes.io/os": "linux"})
This change will make the node selector field in the sriov-device-plugin to take in a variable. This default node selector value is then shared with the code that updates the node selector.