requested changes in https://github.com/k8snetworkplumbingwg/kubemacpool/pull/100#discussion_r388329464

[alonSadan]

#100
in order to keeo track on tohse notes I'm adding them here:

kubemacpool/tests/virtual_machines_test.go

Line 63 in 4a08bf1

Expect(err).ToNot(HaveOccurred())

• Maybe we can keep the failure message, here and and in the rest of the Expects. something like :
  Expect(err).ToNot(HaveOccurred(), "failed to apply the new vm object")

kubemacpool/tests/virtual_machines_test.go

Line 107 in 4a08bf1

Expect(strings.Contains(err.Error(), "failed to allocate requested mac address")).To(Equal(true))

• maybe check that err is not nil, before checking that the error is as expected?

Expect(err).To(HaveOccurred())
Expect(strings.Contains(err.Error(), "failed to allocate requested mac address")).To(Equal(true))

[phoracek]

Could you also share the code you are commenting on? Ideally pinned to a specific revision, like following:

kubemacpool/.gitignore

Line 14 in 75371d2

*.out

https://github.com/k8snetworkplumbingwg/kubemacpool/blob/75371d2d5442ac33f56a8500f58d6bdce19805d5/.gitignore#L14

All the needed information should be in this Issue.

[alonSadan]

sure. Done.