-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue-1168, remove duplicate CVE #1230
Merged
AlexsJones
merged 3 commits into
k8sgpt-ai:main
from
fidelity-contributions:fix-issue-1168
Aug 27, 2024
Merged
fix: issue-1168, remove duplicate CVE #1230
AlexsJones
merged 3 commits into
k8sgpt-ai:main
from
fidelity-contributions:fix-issue-1168
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael12312
changed the title
fix issue-1168, remove duplicate CVE
fix: issue-1168, remove duplicate CVE
Aug 19, 2024
β¦#1164) * getting the error from status field for hpa analyzer Signed-off-by: naveenthangaraj03 <[email protected]> * Signed-off Signed-off-by: naveenthangaraj03 <[email protected]> * Updated the hpaAnalyzer_test.go Signed-off-by: naveenthangaraj03 <[email protected]> * Updated hpa_test.go Signed-off-by: naveenthangaraj03 <[email protected]> * Updated the hpa Signed-off-by: naveenthangaraj03 <[email protected]> * Updated the Conflicts Signed-off-by: naveenthangaraj03 <[email protected]> * Resolved all the conflicts Signed-off-by: naveenthangaraj03 <[email protected]> * Updated the test case Signed-off-by: naveenthangaraj03 <[email protected]> --------- Signed-off-by: naveenthangaraj03 <[email protected]> Co-authored-by: Alex Jones <[email protected]> Co-authored-by: Matthis <[email protected]> Signed-off-by: michael12312 <[email protected]>
Signed-off-by: michael12312 <[email protected]>
Closed #1168 |
gyliu513
reviewed
Aug 22, 2024
kayhern
force-pushed
the
fix-issue-1168
branch
2 times, most recently
from
August 23, 2024 14:21
9c873ef
to
58f2139
Compare
it works for me, thanks @michael12312 |
AlexsJones
approved these changes
Aug 26, 2024
AlexsJones
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An elegant fix, thanks
hi @gyliu513 , @AlexsJones helped approved this PR, can you please help to merge this PR? and close the issue related? |
AlexsJones
pushed a commit
that referenced
this pull request
Oct 24, 2024
Signed-off-by: AlexsJones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
π Description
β Checks
βΉ Additional Information