Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue-1168, remove duplicate CVE #1230

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

michael12312
Copy link
Contributor

Closes #

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@michael12312 michael12312 requested review from a team as code owners August 19, 2024 01:20
@michael12312 michael12312 changed the title fix issue-1168, remove duplicate CVE fix: issue-1168, remove duplicate CVE Aug 19, 2024
naveenthangaraj03 and others added 2 commits August 19, 2024 09:52
…#1164)

* getting the error from status field for hpa analyzer

Signed-off-by: naveenthangaraj03 <[email protected]>

* Signed-off

Signed-off-by: naveenthangaraj03 <[email protected]>

* Updated the hpaAnalyzer_test.go

Signed-off-by: naveenthangaraj03 <[email protected]>

* Updated hpa_test.go

Signed-off-by: naveenthangaraj03 <[email protected]>

* Updated the hpa

Signed-off-by: naveenthangaraj03 <[email protected]>

* Updated the Conflicts

Signed-off-by: naveenthangaraj03 <[email protected]>

* Resolved all the conflicts

Signed-off-by: naveenthangaraj03 <[email protected]>

* Updated the test case

Signed-off-by: naveenthangaraj03 <[email protected]>

---------

Signed-off-by: naveenthangaraj03 <[email protected]>
Co-authored-by: Alex Jones <[email protected]>
Co-authored-by: Matthis <[email protected]>
Signed-off-by: michael12312 <[email protected]>
@gyliu513
Copy link
Contributor

Closed #1168

@kayhern kayhern force-pushed the fix-issue-1168 branch 2 times, most recently from 9c873ef to 58f2139 Compare August 23, 2024 14:21
@gyliu513
Copy link
Contributor

it works for me, thanks @michael12312

@AlexsJones @matthisholleville ^^

Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An elegant fix, thanks

@michael12312
Copy link
Contributor Author

hi @gyliu513 ,

@AlexsJones helped approved this PR, can you please help to merge this PR? and close the issue related?

@AlexsJones AlexsJones merged commit 8edb053 into k8sgpt-ai:main Aug 27, 2024
8 checks passed
AlexsJones pushed a commit that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants