Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.24] Update CNI plugins version and add additional plugins from upstream #7482

Closed
brandond opened this issue May 9, 2023 · 1 comment
Assignees
Milestone

Comments

@brandond
Copy link
Member

brandond commented May 9, 2023

@brandond brandond added this to the v1.24.14+k3s1 milestone May 9, 2023
@brandond brandond self-assigned this May 9, 2023
@brandond brandond moved this from New to Peer Review in K3s Development May 10, 2023
@brandond brandond moved this from Peer Review to To Test in K3s Development May 10, 2023
@mdrahman-suse mdrahman-suse self-assigned this May 15, 2023
@fmoral2
Copy link
Contributor

fmoral2 commented May 16, 2023

Validated on Version:

- k3s version v1.24.13+k3s-f575bd1c (f575bd1c)

Environment Details

Infrastructure
Cloud EC2 instance

Node(s) CPU architecture, OS, and Version:
PRETTY_NAME="SUSE Linux Enterprise Server 15 SP4"

Cluster Configuration:
1 node

Server
Config.yaml:

cat /etc/rancher/k3s/config,yaml
write-kubeconfig-mode: 644
token: test

Steps to validate the fix

  1. Install k3s master last commit
  2. Check cni bin version
  3. Check cni flannel plugin version
  4. Deploy a pod with bandwidth annotation
  5. Validate the bandwidth annotation is applied to the pod

Validation Results:

###########    FIX     ###########

Checking version running on host: k3s version v1.24.13+k3s-f575bd1c (f575bd1c)
go version go1.19.8 on ip: 18.119.164.46


### Commands x Expected Values ###

Command: kubectl get pod test-pod -o yaml --kubeconfig= --kubeconfig=/tmp/franlocalk3s_kubeconfig  | grep -A2 annotations  
Expected Value: 1M


Command: /var/lib/rancher/k3s/data/current/bin/cni
Expected Value: CNI plugins plugin v1.2.0-k3s1

---------------------------------------------------------------------------------------



CMD: kubectl get pod test-pod -o yaml --kubeconfig= --kubeconfig=/tmp/franlocalk3s_kubeconfig  | grep -A2 annotations

RESULT:   
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"v1","kind":"Pod","metadata":{"annotations":{"kubernetes.io/egress-bandwidth":"1M","kubernetes.io/ingress-bandwidth":"1M"},"name":"test-pod","namespace":"default"},"spec":{"containers":[{"command":["sh","-c","echo The app is running! \u0026\u0026 sleep 3600"],"image":"busybox","name":"test-container"}]}}
kubernetes.io/egress-bandwidth: 1M
kubernetes.io/ingress-bandwidth: 1M

Assertion: 1M

Matched with:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"v1","kind":"Pod","metadata":{"annotations":{"kubernetes.io/egress-bandwidth":"1M","kubernetes.io/ingress-bandwidth":"1M"},"name":"test-pod","namespace":"default"},"spec":{"containers":[{"command":["sh","-c","echo The app is running! \u0026\u0026 sleep 3600"],"image":"busybox","name":"test-container"}]}}
kubernetes.io/egress-bandwidth: 1M
kubernetes.io/ingress-bandwidth: 1M



CMD: /var/lib/rancher/k3s/data/current/bin/cni

RESULT: CNI plugins plugin v1.2.0-k3s1
CNI protocol versions supported: 0.1.0, 0.2.0, 0.3.0, 0.3.1, 0.4.0, 1.0.0


Assertion: CNI plugins plugin v1.2.0-k3s1

Matched with:
CNI plugins plugin v1.2.0-k3s1
CNI protocol versions supported: 0.1.0, 0.2.0, 0.3.0, 0.3.1, 0.4.0, 1.0.0

@fmoral2 fmoral2 closed this as completed May 16, 2023
@github-project-automation github-project-automation bot moved this from To Test to Done Issue in K3s Development May 16, 2023
@fmoral2 fmoral2 self-assigned this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants