Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kine to v0.10.1 #7410

Closed
brandond opened this issue May 2, 2023 · 6 comments
Closed

Bump kine to v0.10.1 #7410

brandond opened this issue May 2, 2023 · 6 comments
Assignees
Milestone

Comments

@brandond
Copy link
Member

brandond commented May 2, 2023

Kine v0.10.1 contains a number of bugfixes and enhancementes, see k3s-io/kine@v0.9.9...v0.10.1

We should update k3s to this version.

Note: at this time I am not planning on enabling the embedded nats support, which adds ~1mb to the shipping k3s binary size.

@brandond brandond self-assigned this May 2, 2023
@brandond brandond moved this from New to Working in K3s Development May 2, 2023
@brandond brandond added this to the v1.27.2+k3s1 milestone May 2, 2023
@bruth
Copy link
Contributor

bruth commented May 4, 2023

@brandond Curious to know what the plan would be on when embedded NATS will be included?

It is also worth noting that when it does become enabled, it will result it defaulting to the embedded server unless the endpoint URL explicitly has the noEmbed URL param. For existing k3s deployments upgrading that are relying on an external NATS cluster, this param would need to be added.

@brandond
Copy link
Member Author

brandond commented May 4, 2023

@bruth Not sure, but that is a great callout that didn't occur to me.

I wonder if perhaps we should make an additional change to kine so that the embedded server is only enabled by default with the nats:// endpoint scheme, so that anyone using the legacy jetstream:// scheme will get the old behavior of connecting to the given address. This would avoid breaking users when we add the embedded server support.

@bruth
Copy link
Contributor

bruth commented May 4, 2023

I think that is a good idea. I will open a PR to revert to that behavior. That would also make it more comfortable to include embedded NATS to k3s to not change behavior.. especially if its only a 1MB increase?

@brandond
Copy link
Member Author

brandond commented May 4, 2023

yeah absolutely. I am working on moving containerd back into the main binary which will save us 11MB, so that'll give us more room for nats ;)

@bruth
Copy link
Contributor

bruth commented May 4, 2023

PR for Kine: k3s-io/kine#184

@brandond brandond moved this from Working to To Test in K3s Development May 5, 2023
@brandond brandond changed the title Bump kine to v0.10.0 Bump kine to v0.10.1 May 5, 2023
@bguzman-3pillar
Copy link

Validated kine v0.10.1 version using go.mod on 1.27 branch

Look for line 108

image

@github-project-automation github-project-automation bot moved this from To Test to Done Issue in K3s Development May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants