From fb870adb911c85e32f9e771a14cd29955c4a4acf Mon Sep 17 00:00:00 2001 From: Derek Nola Date: Thu, 6 Mar 2025 08:55:13 -0800 Subject: [PATCH] Reenable skew test for 1.32/master (#11885) Signed-off-by: Derek Nola --- tests/docker/skew/skew_test.go | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/tests/docker/skew/skew_test.go b/tests/docker/skew/skew_test.go index a48563eda6f6..78b76026c878 100644 --- a/tests/docker/skew/skew_test.go +++ b/tests/docker/skew/skew_test.go @@ -32,20 +32,11 @@ var _ = BeforeSuite(func() { // For master and unreleased branches, we want the latest stable release var upgradeChannel string var err error - if *channel == "latest" || *channel == "v1.32" { - // disabled: AuthorizeNodeWithSelectors is now on by default, which breaks compat with agents < v1.32. - // This can be ren-enabled once the previous branch is v1.32 or higher, or when RBAC changes have been backported. - // ref: https://github.com/kubernetes/kubernetes/pull/128168 - Skip("Skipping version skew tests for " + *channel + " due to AuthorizeNodeWithSelectors") - - upgradeChannel = "stable" - } else { - // We want to substract one from the minor version to get the previous release - sV, err := semver.ParseTolerant(*channel) - Expect(err).NotTo(HaveOccurred(), "failed to parse version from "+*channel) - sV.Minor-- - upgradeChannel = fmt.Sprintf("v%d.%d", sV.Major, sV.Minor) - } + // We want to substract one from the minor version to get the previous release + sV, err := semver.ParseTolerant(*channel) + Expect(err).NotTo(HaveOccurred(), "failed to parse version from "+*channel) + sV.Minor-- + upgradeChannel = fmt.Sprintf("v%d.%d", sV.Major, sV.Minor) lastMinorVersion, err = tester.GetVersionFromChannel(upgradeChannel) Expect(err).NotTo(HaveOccurred())