Skip to content
This repository has been archived by the owner on Oct 13, 2022. It is now read-only.

To be more Pythonic #49

Open
csukuangfj opened this issue Dec 18, 2020 · 2 comments
Open

To be more Pythonic #49

csukuangfj opened this issue Dec 18, 2020 · 2 comments

Comments

@csukuangfj
Copy link
Collaborator

There exist shell scripts and Perl scripts for data preparation, most of which are modified from Kaldi. They provide extra
functionalities that are actually not needed in snowfall.

I would suggest doing as many things as possible in Python and getting rid of shell scripts and Perl scripts as best as we can.

@danpovey
Copy link
Contributor

Sure, but bear in mind that the whole idea of Snowfall (vs. Icefall) is "move fast and break things". At this point our main goal is to get a prototype working and debug k2 and lhotse, so while eventually we'll want to do things more Pythonically, let's not prioritize it too highly.

@pzelasko
Copy link
Collaborator

+1 to what both of you are saying. These scripts are also on my radar, but I'm refraining myself from touching that as I'd prefer to contribute to a working recipe first :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants