Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max speakers for speaker embedding manager #1096

Closed
thewh1teagle opened this issue Jul 9, 2024 · 3 comments · Fixed by #1102
Closed

max speakers for speaker embedding manager #1096

thewh1teagle opened this issue Jul 9, 2024 · 3 comments · Fixed by #1102

Comments

@thewh1teagle
Copy link
Contributor

thewh1teagle commented Jul 9, 2024

It would be useful if I there was an option in embedding manager to find the closest one from existing speakers.
This way, I can handle myself the case where I know how many speakers there are, and there's already enough speakers detected.

@csukuangfj
Copy link
Collaborator

That sounds reasonable.

Could you follow

float max_score = scores.maxCoeff(&max_index);

to add a TopK to return the name and scores for the topK match?

@thewh1teagle
Copy link
Contributor Author

thewh1teagle commented Jul 9, 2024

to add a TopK to return the name and scores for the topK match?

I assume we just need to sort the scores, then iterate through them, collect, and return. Could you share any specific IntelliSense and formatting settings used in the repository so I can feel more comfortable working in VSCode?

@csukuangfj
Copy link
Collaborator

We are using clang-format, which can be installed with

pip install clang-format

I don't use VSCode. Maybe you can find a way to integrate clang-format with it.

You don't need to care about the style issues. We can reformat the file later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants