Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yml parse error? #299

Closed
atsushi-ishibashi opened this issue Nov 21, 2022 · 4 comments · Fixed by #300
Closed

yml parse error? #299

atsushi-ishibashi opened this issue Nov 21, 2022 · 4 comments · Fixed by #300

Comments

@atsushi-ishibashi
Copy link
Contributor

atsushi-ishibashi commented Nov 21, 2022

when you define vars with double quote, it seems to ignore yml config? The result is the same when single quote.

desc: basicauth
vars:
  user: "hoge"
  password: "pass@?$"
steps:
  basicAuth:
    bind:
      basicToken: base64encode(vars.user + ':' + vars.password)
  output:
    dump: basicToken
$ runn run ./book.yml --debug
Generated by `runn new` ... ok

1 scenario, 0 skipped, 0 failures

if you remove double quote, it works well

desc: basicauth
vars:
  user: hoge
  password: pass@?$
steps:
  basicAuth:
    bind:
      basicToken: base64encode(vars.user + ':' + vars.password)
  output:
    dump: basicToken
$ runn run ./book.yml --debug
Run 'bind' on 'basicauth'.steps.basicAuth

Run 'dump' on 'basicauth'.steps.output
aG9nZTpwYXNzQD8k
basicauth ... ok

1 scenario, 0 skipped, 0 failures
@k1LoW
Copy link
Owner

k1LoW commented Nov 21, 2022

Seems to be an issue with https://github.com/k1LoW/expand

b = expand.ExpandenvYAMLBytes(b)

I'll check it out.

@k1LoW
Copy link
Owner

k1LoW commented Nov 21, 2022

Looks like k1loW/expand is responding to $.

@atsushi-ishibashi
Copy link
Contributor Author

you're right. the below works well

desc: basicauth
vars:
  user: "hoge"
  password: "pass@?"
steps:
  basicAuth:
    bind:
      basicToken: base64encode(vars.user + ':' + vars.password)
  output:
    dump: basicToken

@k1LoW
Copy link
Owner

k1LoW commented Nov 21, 2022

Fixed in v0.49.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants