-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop kardianos/service dependency #4962
Comments
|
16 tasks
16 tasks
This was referenced Sep 30, 2024
The issue is marked as stale since no activity has been recorded in 30 days |
We had a bug in the current implementation (here is the fix), so let's also add some unit tests to make sure, that the generated services are correct |
16 tasks
The issue is marked as stale since no activity has been recorded in 30 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We anyways already provide our own templates for system units and thus do not depend that much on the library functionality.
kardianos/service is not really maintained, there's e.g. a bug fix PR opened by myself on June 2023 which has not been merged.
I propose that we drop the whole dependency, use our own templates fully and provide needed wrappers around. We handle much of the same/similar logic in k0sctl/rig side already and thus known what needs to be done.
The text was updated successfully, but these errors were encountered: