-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout_millis for nested remap #82
Conversation
That's wonderful. just finished the build and did a couple of tests here's the config that I have used:
the issue is if I click another note: it would be very nice if we can control the default 500ms. |
For backward compatibility, when it doesn't have a timeout, it doesn't timeout. I think it's natural from how it's configured, too. |
Even if I want to I can't assign a timeout to the first
Error: "mapping values are not allowed in the context ..." |
It's top-level, there's nothing to be timed out. All you need is #82 (comment). |
I don't understand, it doesn't work ... pressing that's not the behavior of what this feature should achieve. |
In case I confused you by replying a short meesage,
I still intend to fix this. However, it doesn't still change the fact that the correct config is: keymap:
- remap:
j:
remap:
k: Esc
timeout_millis: 200 because of how the indent level impacts which key. |
I updated the implementation. This YAML: keymap:
- remap:
j:
remap:
k: Esc
timeout_millis: 200 behaves like:
|
Hello, the config is working as expected now. for example below is the only behavior that's missing j -> 200ms or more, user didn't follow with another key press ...
Thank you. |
I updated the implementation. This YAML: keymap:
- remap:
j:
remap:
k: Esc
timeout_millis: 200 behaves like:
|
I'm running on the new implementation, so far it is working great. Give me a couple of days to test it and I'll report if something Thank you so much! |
Maybe it's time to release this? |
Yes, just merge the branch. I'm very happy with the results. |
Thank you for your patience and testing. |
Example
I updated the implementation. This YAML: