Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding an IssuerRegistration #16

Open
rwinch opened this issue Jun 22, 2018 · 3 comments
Open

Consider adding an IssuerRegistration #16

rwinch opened this issue Jun 22, 2018 · 3 comments

Comments

@rwinch
Copy link
Collaborator

rwinch commented Jun 22, 2018

Summary

Central to the client code is a ClientRegistration which contains the meta information for a client to interact with authorization servers. Similarly, I think something like an IssuerRegistration would be beneficial to the resource server side.

I don't have a timeline on this issue yet and am not convinced we need or should do this. I am just wanting to get this issue logged so we don't forget and can discuss.

I'm not sure I like the name because issuers are used by clients too, so we may need to work on the name, but I'm using IssuerRegistration as a placeholder for now.

@jzheaux
Copy link
Owner

jzheaux commented Jun 22, 2018

Was thinking about this too, and actually had an IssuerRegistration object at one point locally, trying to see how this might be modeled.

I think Keycloak has an interesting way to think about it, and that is as a realm. A realm, in Keycloak, maps to a set of OAuth2 endpoints--JWK Set, Token, etc.--a set of clients, users, and roles, etc. in order to support a multi-tenant Keycloak deployment.

It provides a clear mapping to what realm to send back in error messages on the resource server side.

Long story short, another name might be RealmRegistration. We could infer realm name from it as well as issuer endpoints.

@jgrandja
Copy link
Collaborator

@jzheaux Can you provide a link to the Keycloak class. I'm curious how it's structured.

@jzheaux
Copy link
Owner

jzheaux commented Jun 22, 2018

Oh, sorry, I'm speaking about how the Keycloak AS is structured.

I do have a link to their resource-server multi-tenancy support [1], though to be clear, that isn't what I was referring to above. Still, this link is related to the larger conversation, though.

[1] - https://github.com/thomasdarimont/spring-boot-2-keycloak-oauth-example/blob/feature/mulit-tenancy/src/main/java/demo/SpringBoot2App.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants