[ICE] panic on %=

[jyn514]

Expected behavior
i %= j should be the same as i = i % j

Actual Behavior
RCC crashes.

Code

int main () { float f = 3; return f %= 2,1; }
thread 'main' panicked at 'internal error: entered unreachable code: only valid assign binary ops should be passed to binary_assign_op (got %)', src/ir/expr.rs:324:30

Backtrace

  13: rcc::ir::expr::<impl rcc::ir::Compiler>::binary_assign_ir
  14: rcc::ir::expr::<impl rcc::ir::Compiler>::assignment
  15: rcc::ir::expr::<impl rcc::ir::Compiler>::compile_expr
  16: rcc::ir::expr::<impl rcc::ir::Compiler>::compile_expr
  17: rcc::ir::expr::<impl rcc::ir::Compiler>::cast
  18: rcc::ir::expr::<impl rcc::ir::Compiler>::compile_expr
  19: rcc::ir::stmt::<impl rcc::ir::Compiler>::compile_stmt
  20: rcc::ir::stmt::<impl rcc::ir::Compiler>::compile_all
  21: rcc::ir::Compiler::compile_func
  22: rcc::ir::compile
  23: rcc::compile
  24: rcc::real_main
  25: rcc::main

Thanks to @Byter09 for the fuzzing.

[jyn514]

This should have been caught by the parser, % is invalid for floats.

[jyn514]

Waiting on #151 , same reasoning as #121 .

[pythongirl325]

Does this also hold for similar operators like ^=?

[jyn514]

Yes, they all need to be desugared so they do typechecking properly.