Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: --text-page-separator option ignores empty pages #45

Closed
sokolgeo opened this issue Nov 9, 2024 · 0 comments
Closed

Bug: --text-page-separator option ignores empty pages #45

sokolgeo opened this issue Nov 9, 2024 · 0 comments

Comments

@sokolgeo
Copy link

sokolgeo commented Nov 9, 2024

Hi, since your very kind implementation of the --text-page-separator in #44, there seems to be a bug in the current implementation.

Empty pages seems to be completely ignored by the --text-page-separator output. This makes the implementation essentially useless for the purpose, because you can not simply attach this text output page-by-page as invisible search layer to pdf printout as pages in pdf and txt will not match each other after the first empty page in the document.

Minimal example attached: 20241109_144728.zip

It's a three page note with pages 1 and 3 containing "x" and page 2 is empty. When running supernote-tool convert -t txt -a --text-page-separator='-- my unique page separator --' 20241109_144728.note output.txt the resulting output is:

x
-- my unique page separator --
x

I believe the correct implementation should produce instead:

x
-- my unique page separator --
-- my unique page separator --
x

Could you please look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant