OWA-99: fix: do not perform logout if password reset with token #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirovladimitrovski
requested review from
AntonLantukh and
dbudzins
as code owners
|
Visit the preview URL for this PR (updated for commit a349b22): https://ottwebapp--pr648-owa-99-prevent-logou-hvg6tdxy.web.app (expires Fri, 27 Dec 2024 15:37:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
mirovladimitrovski
changed the title
AntonLantukh
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves OWA-99.
Whenever a password change or reset is requested and finished successfully, we're performing a logout request afterwards. This is fine is the password change is requested by a logged in user. But the logout request should NOT be performed when a logged out user has forgotten their password and starts a process for resetting their password. With changes in this PR the logout request will only be made if there is a user logged in.
Steps completed:
According to our definition of done, I have completed the following steps: