-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix / prevent recommendations as feed #617
Fix / prevent recommendations as feed #617
Conversation
Visit the preview URL for this PR (updated for commit 7fb8f0d): https://ottwebapp--pr617-fix-prevent-recommen-mrbxqbpn.web.app (expires Fri, 03 Jan 2025 16:23:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted! Tested and works ✅
@ChristiaanScheermeijer I think |
@AntonLantukh do you suggest that we should use the recommendations feed by default in the MediaEvent page instead of the |
@ChristiaanScheermeijer sorry for the delay, lots of things happening. |
3cc10b7
to
7fb8f0d
Compare
@AntonLantukh I rebased and updated the PR! |
Description
This small fix prevents the recommendations playlist ending up in the feed param (
?r=:feedId
). This can cause problems when navigating to a different screen that does consume the feed for fetching the playlist.Reproduction: