Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add module to Ionic 4 project #1

Open
jahertor opened this issue Jun 12, 2019 · 3 comments
Open

Can't add module to Ionic 4 project #1

jahertor opened this issue Jun 12, 2019 · 3 comments

Comments

@jahertor
Copy link

I follow the instructions to get it working on Ionic 4 but with no success:

import { ToastUiImageEditorModule } from "toast-ui-image-editor";

Failed to compile.

./src/app/app.module.ts
Module not found: Error: Can't resolve 'toast-ui-image-editor' in 'path-to-project'

@UAjinkya
Copy link

I follow the instructions to get it working on Ionic 4 but with no success:

import { ToastUiImageEditorModule } from "toast-ui-image-editor";

Failed to compile.
./src/app/app.module.ts
Module not found: Error: Can't resolve 'toast-ui-image-editor' in 'path-to-project'

You have to import
import { ToastUiImageEditorModule } from 'ngx-tui-image-editor';

@arimus
Copy link

arimus commented Sep 2, 2019

YMMV, but this is likely related to the way tui-image-editor is set up. If you use esModuleInterop / allowSyntheticDefaultImports: true in your tsconfig.json you may get past this issue. Warning though...this can create problems with other modules. Currently bootstrap popovers essentially hard lock the browser when using this flag. I think that this module would have to essentially bundle the tui-image-editor to get around the issue completely. Hopefully the tui-image-editor folks create a solution for us which does not involve esModuleInterop / allowSyntheticDefaultImports.

nhn/tui.image-editor#219

@arimus
Copy link

arimus commented Sep 3, 2019

FYI, it seems that allowSyntheticDefaultImports in a simple base app works just fine, even with bootstrap popovers. There must be something else in my stack (ngx-admin is a base project I'm using atm) that's unhappy once webpack does all it's magic and causes the lockups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants