Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update READEME to include info on how to add feature modules. #275

Open
broweratcognitecdotcom opened this issue Jan 29, 2018 · 5 comments

Comments

@broweratcognitecdotcom
Copy link

The generator generates a single module containing all of the components, services, etc. It is not obvious how to separate the library's module into various feature modules. Can you please update the README and add this information or, update the generator so that it creates feature modules? Thanks for this excellent generator.

@jvandemo
Copy link
Owner

jvandemo commented Feb 4, 2018

@broweratcognitecdotcom — Would you be interested in creating a PR for this? Thanks in advance!

@broweratcognitecdotcom
Copy link
Author

I will see what I can do in the evenings this week.

@jvandemo
Copy link
Owner

jvandemo commented Feb 6, 2018

@broweratcognitecdotcom — Thank you, much appreciated! 👍

@robertbrower-technologies

Just to give you an update on this...

My confusion / concern stemmed somehow from the example. I guess because I was new with the generator. But I had stuffed all my components, directives, pipes, and services into one NgModule, as in the example, in more than one node package in our Angular project here. Later I discovered that it is a subjective decision that really depends on architecture and had to refactor because I found that if I just needed one component out of many in the NgModule of the node package, I was forced to import the entire NgModule which caused my app size to be larger than needed. So I split things up more sensibly and created a NgModule for each component, directive, pipe, and service. I think as a new user of the generator, I had not grasped that idea from the start which forced me to refactor later.

So, while I have figured out how to create feature modules, i wanted to ask you if you thought that it was too subjective and unnecessary. Or if you think it makes sense to modify the sample module so that it includes modules for the component, directive, pipe, and service. If so then I will try to help. Thanks again for the nice generator.

@justageek
Copy link

Hi, I'd be interested in this too, we do need the namespaced series of components in a package, similar to Angular Material, core, etc. But, I admin that I have no idea where to start to make that happen with this builder, but I'm willing to help if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants