Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added back service discovery namespace and more instance types #4

Conversation

applike-ss
Copy link
Contributor

@applike-ss applike-ss commented Dec 6, 2022

Description

fixes #3

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@applike-ss applike-ss force-pushed the add-back-service-discovery-namespace-and-more-instance-types branch 2 times, most recently from fb5966a to 44666fe Compare December 7, 2022 07:44
@applike-ss applike-ss changed the title added back service discovery namespace and more instance types feat: added back service discovery namespace and more instance types Dec 7, 2022
@applike-ss applike-ss changed the title feat: added back service discovery namespace and more instance types feat: Added back service discovery namespace and more instance types Dec 7, 2022
@applike-ss applike-ss force-pushed the add-back-service-discovery-namespace-and-more-instance-types branch 2 times, most recently from 10f1681 to 38a1221 Compare December 7, 2022 07:47
@applike-ss applike-ss force-pushed the add-back-service-discovery-namespace-and-more-instance-types branch from 38a1221 to fc0347b Compare December 7, 2022 08:44
@applike-ss applike-ss marked this pull request as ready for review December 7, 2022 08:46
@applike-ss applike-ss requested a review from j4k4 December 7, 2022 08:46
@applike-ss applike-ss merged commit 408f159 into justtrackio:main Dec 7, 2022
mfroembgen pushed a commit that referenced this pull request Dec 7, 2022
## [1.1.0](v1.0.0...v1.1.0) (2022-12-07)

### Features

* Added back service discovery namespace and more instance types ([#4](#4)) ([408f159](408f159))
@mfroembgen
Copy link
Contributor

This PR is included in version 1.1.0 🎉

@github-actions
Copy link

github-actions bot commented Jan 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back service discovery namespace
3 participants