Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust service discovery name #4

Merged
merged 2 commits into from
Jan 4, 2023
Merged

fix: Adjust service discovery name #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94e9bcb
fix: Adjust service discovery name
Jan 4, 2023
df50e81
fix: Adjust service discovery name
Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/all-labels/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ terraform {
}
}

required_version = "1.3.6"
required_version = ">= 1.3.6"
}
2 changes: 1 addition & 1 deletion examples/basic/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ terraform {
}
}

required_version = "1.3.6"
required_version = ">= 1.3.6"
}
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ module "redis" {

resource "aws_service_discovery_service" "this" {
count = var.use_redis ? 1 : 0
name = "kvstore_${try(var.attributes[0], "")}.${module.this.name}.redis"
name = "kvstore_${try(var.attributes[0], "")}.${module.this.stage}-${module.this.name}.redis"

dns_config {
namespace_id = var.redis_service_discovery_dns_namespace_id
Expand Down