From 5e4cde0f1ba46affa5a908fce8e615a78134ff5f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Stru=C3=9F?=
 <31846129+applike-ss@users.noreply.github.com>
Date: Wed, 21 Feb 2024 12:16:00 +0100
Subject: [PATCH] feat: allow ecs service changes (e.g. image updates) (#39)

## Description
<!--- Describe your changes in detail -->

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->

## Breaking Changes
<!-- Does this break backwards compatibility with the current major
version? -->
<!-- If so, please provide an explanation why it is necessary. -->

## How Has This Been Tested?
- [ ] I have updated at least one of the `examples/*` to demonstrate and
validate my change(s)
- [ ] I have tested and validated these changes using one or more of the
provided `examples/*` projects
<!--- Users should start with an existing example as its written, deploy
it, then check their changes against it -->
<!--- This will highlight breaking/disruptive changes. Once you have
checked, deploy your changes to verify -->
<!--- Please describe how you tested your changes -->
- [ ] I have executed `pre-commit run -a` on my pull request
<!--- Please see
https://github.com/antonbabenko/pre-commit-terraform#how-to-install for
how to install -->
---
 README.md    |  1 +
 main.tf      | 15 ++++++++-------
 variables.tf |  6 ++++++
 3 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/README.md b/README.md
index e3f94ff..7408b99 100644
--- a/README.md
+++ b/README.md
@@ -51,6 +51,7 @@
 | <a name="input_environment"></a> [environment](#input\_environment) | ID element. Usually used for region e.g. 'uw2', 'us-west-2', OR role 'prod', 'staging', 'dev', 'UAT' | `string` | `null` | no |
 | <a name="input_environment_variables"></a> [environment\_variables](#input\_environment\_variables) | The environment variables to pass to the container. This is a map of string: {key: value}. map\_environment overrides environment | `map(string)` | `null` | no |
 | <a name="input_id_length_limit"></a> [id\_length\_limit](#input\_id\_length\_limit) | Limit `id` to this many characters (minimum 6).<br>Set to `0` for unlimited length.<br>Set to `null` for keep the existing setting, which defaults to `0`.<br>Does not affect `id_full`. | `number` | `null` | no |
+| <a name="input_ignore_changes_task_definition"></a> [ignore\_changes\_task\_definition](#input\_ignore\_changes\_task\_definition) | Whether to ignore changes in container definition and task definition in the ECS service | `bool` | `false` | no |
 | <a name="input_label_key_case"></a> [label\_key\_case](#input\_label\_key\_case) | Controls the letter case of the `tags` keys (label names) for tags generated by this module.<br>Does not affect keys of tags passed in via the `tags` input.<br>Possible values: `lower`, `title`, `upper`.<br>Default value: `title`. | `string` | `null` | no |
 | <a name="input_label_order"></a> [label\_order](#input\_label\_order) | The order in which the labels (ID elements) appear in the `id`.<br>Defaults to ["namespace", "environment", "stage", "name", "attributes"].<br>You can omit any of the 6 labels ("tenant" is the 6th), but at least one must be present. | `list(string)` | `null` | no |
 | <a name="input_label_orders"></a> [label\_orders](#input\_label\_orders) | Overrides the `labels_order` for the different labels to modify ID elements appear in the `id` | <pre>object({<br>    cloudwatch = optional(list(string)),<br>    ecs        = optional(list(string)),<br>    iam        = optional(list(string)),<br>    vpc        = optional(list(string))<br>  })</pre> | `{}` | no |
diff --git a/main.tf b/main.tf
index ec7ff9e..6fad321 100644
--- a/main.tf
+++ b/main.tf
@@ -151,13 +151,14 @@ module "ecs_service_task" {
   source  = "justtrackio/ecs-alb-service-task/aws"
   version = "1.0.0"
 
-  container_definition_json = "[${module.node_exporter_definition.json_map_encoded},${module.cadvisor_definition.json_map_encoded}]"
-  ecs_cluster_arn           = var.ecs_cluster_arn
-  launch_type               = "EC2"
-  scheduling_strategy       = "DAEMON"
-  task_cpu                  = var.task_cpu
-  task_memory               = var.task_memory
-  network_mode              = "host"
+  container_definition_json      = "[${module.node_exporter_definition.json_map_encoded},${module.cadvisor_definition.json_map_encoded}]"
+  ecs_cluster_arn                = var.ecs_cluster_arn
+  ignore_changes_task_definition = var.ignore_changes_task_definition
+  launch_type                    = "EC2"
+  scheduling_strategy            = "DAEMON"
+  task_cpu                       = var.task_cpu
+  task_memory                    = var.task_memory
+  network_mode                   = "host"
   docker_volumes = [
     {
       host_path                   = "/"
diff --git a/variables.tf b/variables.tf
index 63dd427..eb3d6c0 100644
--- a/variables.tf
+++ b/variables.tf
@@ -39,6 +39,12 @@ variable "environment_variables" {
   default     = null
 }
 
+variable "ignore_changes_task_definition" {
+  type        = bool
+  description = "Whether to ignore changes in container definition and task definition in the ECS service"
+  default     = false
+}
+
 variable "label_orders" {
   type = object({
     cloudwatch = optional(list(string)),