diff --git a/ng2-material/components/backdrop/backdrop.ts b/ng2-material/components/backdrop/backdrop.ts index 28c8c596..00825505 100644 --- a/ng2-material/components/backdrop/backdrop.ts +++ b/ng2-material/components/backdrop/backdrop.ts @@ -33,26 +33,26 @@ export class MdBackdrop { * Emits when the backdrop begins to hide. */ @Output() - onHiding: EventEmitter = new EventEmitter(); + onHiding: EventEmitter = new EventEmitter(false); /** * Emits when the backdrop has finished being hidden. */ @Output() - onHidden: EventEmitter = new EventEmitter(); + onHidden: EventEmitter = new EventEmitter(false); /** * Emits when the backdrop begins to be shown. */ @Output() - onShowing: EventEmitter = new EventEmitter(); + onShowing: EventEmitter = new EventEmitter(false); /** * Emits when the backdrop has finished being shown. */ @Output() - onShown: EventEmitter = new EventEmitter(); + onShown: EventEmitter = new EventEmitter(false); constructor(public element: ElementRef) { } diff --git a/ng2-material/components/checkbox/checkbox.ts b/ng2-material/components/checkbox/checkbox.ts index 8acde389..4a9990f5 100644 --- a/ng2-material/components/checkbox/checkbox.ts +++ b/ng2-material/components/checkbox/checkbox.ts @@ -32,7 +32,7 @@ import {parseTabIndexAttribute} from "../../core/util/util"; export class MdCheckbox { @Output() - checkedChange: EventEmitter = new EventEmitter(); + checkedChange: EventEmitter = new EventEmitter(false); /** Whether this checkbox is checked. */ @Input() diff --git a/ng2-material/components/dialog/dialog.ts b/ng2-material/components/dialog/dialog.ts index 049f4511..3350402e 100644 --- a/ng2-material/components/dialog/dialog.ts +++ b/ng2-material/components/dialog/dialog.ts @@ -26,8 +26,6 @@ export * from './dialog_container'; export * from './dialog_ref'; export * from './dialog_basic'; -// TODO(jelbourn): body scrolling is disabled while dialog is open. -// TODO(jelbourn): Don't manually construct and configure a DOM element. See #1402 // TODO(jelbourn): Wrap focus from end of dialog back to the start. Blocked on #1251 // TODO(jelbourn): Focus the dialog element when it is opened. // TODO(jelbourn): Pre-built `alert` and `confirm` dialogs. @@ -110,13 +108,7 @@ export class MdDialog { backdropRef.instance.hide().then(() => { containerRef.dispose(); contentRef.dispose(); - // TODO(jd): The change detection doesn't like it if you dispose() a ComponentRef while it has - // pending async things that will emit() one of it's outputs. Wait a second for the - // container objects to be disposed and clean up their Change detection references to - // the backdrop's hide/show events, then dispose of the backdrop. - TimerWrapper.setTimeout(()=> { - backdropRef.dispose(); - }, 500); + backdropRef.dispose(); }); }); }); diff --git a/ng2-material/components/ink/ink.ts b/ng2-material/components/ink/ink.ts index 42cb1419..a74fb7af 100644 --- a/ng2-material/components/ink/ink.ts +++ b/ng2-material/components/ink/ink.ts @@ -9,7 +9,7 @@ import {Ink} from "../../core/util/ink"; }) export class MdInk { - @Output() inked:EventEmitter = new EventEmitter(); + @Output() inked:EventEmitter = new EventEmitter(false); constructor(private _element: ElementRef) { } diff --git a/ng2-material/components/input/input.ts b/ng2-material/components/input/input.ts index 88fd46b2..8a7b7fb8 100644 --- a/ng2-material/components/input/input.ts +++ b/ng2-material/components/input/input.ts @@ -47,9 +47,9 @@ export class MdInput { @Input() placeholder: string; @Output('valueChange') - mdChange: EventEmitter = new EventEmitter(); + mdChange: EventEmitter = new EventEmitter(false); @Output() - mdFocusChange: EventEmitter = new EventEmitter(); + mdFocusChange: EventEmitter = new EventEmitter(false); setHasFocus(hasFocus: boolean) { ObservableWrapper.callEmit(this.mdFocusChange, hasFocus); diff --git a/ng2-material/components/radio/radio_button.ts b/ng2-material/components/radio/radio_button.ts index 93a8d5f9..b8de5bd8 100644 --- a/ng2-material/components/radio/radio_button.ts +++ b/ng2-material/components/radio/radio_button.ts @@ -44,7 +44,7 @@ var _uniqueIdCounter: number = 0; export class MdRadioGroup implements OnChanges { @Output('valueChange') - change: EventEmitter = new EventEmitter(); + change: EventEmitter = new EventEmitter(false); /** The selected value for the radio group. The value comes from the options. */ @Input('value')