Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Fields whose Type is a Flag Enumeration to be Stored as Relations #49

Open
justin-millman opened this issue Aug 14, 2022 · 0 comments
Labels
enhancement New feature or request extraction Applies to the Extraction Layer reconstitution Applies to the Reconstitution Layer translation Applies to the Translation Layer

Comments

@justin-millman
Copy link
Owner

I don't think that the current features in either the Extraction or Reconstitution space are sufficient to support flag-enumeration-type Fields that are to be stored as a Relation. (I don't even think there's a way right now to indicate that they should be.)

  • Indication is straightforward: Just add a new annotation
  • How do we deal with inserts vs. deletes vs. saves on Extraction, given that we won't have the tracking that comes from an IRelation?
  • How do we do Reconstitution, given that we won't be able to Repopulate like we can with an IRelation?
  • Do data conversions apply to the individual flags? I think the answer is yes: the Field gets treated as if it were a RelationList<EnumT>, so any data conversion (e.g. [Numeric] or to-string as default or custom converter annotation) would get applied to the items in the Relation, just like with any other Relation.

Important Question: Should Relation-style be the default for such Fields, with an opt-out?

@justin-millman justin-millman added enhancement New feature or request v1.0.0 This issue must be closed before v1.0.0 can release translation Applies to the Translation Layer extraction Applies to the Extraction Layer reconstitution Applies to the Reconstitution Layer labels Aug 14, 2022
@justin-millman justin-millman removed the v1.0.0 This issue must be closed before v1.0.0 can release label Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request extraction Applies to the Extraction Layer reconstitution Applies to the Reconstitution Layer translation Applies to the Translation Layer
Projects
None yet
Development

No branches or pull requests

1 participant