Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest snapshots fail with Angular 15.2.2 #1350

Closed
mkemmerling opened this issue Mar 29, 2023 · 2 comments
Closed

Jest snapshots fail with Angular 15.2.2 #1350

mkemmerling opened this issue Mar 29, 2023 · 2 comments

Comments

@mkemmerling
Copy link

Jest snapshots are broken with Angular 15.2.2. The reason is that Ivy detection fails in jest-preset-angular 12.2.6 (no ɵivyEnabled anymore in @angular/core). This is fixed in jest-preset-angular 13.0.1, see thymikee/jest-preset-angular#2003 and https://github.com/thymikee/jest-preset-angular/blob/v13.0.1/CHANGELOG.md.

@sceed1
Copy link

sceed1 commented Apr 11, 2023

Problem for me is that @angular-builders/jest requires [email protected] which produces the following warnings:

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/jest
npm WARN   dev jest@"29.5.0" from the root project
npm WARN   2 more (@angular-builders/jest, jest-when)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer jest@"^28.0.0" from [email protected]
npm WARN node_modules/@angular-builders/jest/node_modules/jest-preset-angular
npm WARN   jest-preset-angular@"12.2.3" from @angular-builders/[email protected]
npm WARN   node_modules/@angular-builders/jest

@just-jeb
Copy link
Owner

just-jeb commented Apr 13, 2023

The upgrade to Jest 29 (as well as to jest-preset-angular 13) will happen with the major release of Angular Builders 16, which, in turn, will happen with the major release of Angular 16. This is because there are potentially breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants