fix(auth_methods): Add checks for duplicate auth_method in create API
#5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMani
added
C-bug
racnan
reviewed
Jul 1, 2024
| pub async fn construct_public_and_private_db_configs( | ||
| auth_config: &user_api::AuthConfig, | ||
| encryption_key: &[u8], | ||
| ) -> UserResult<(Option<Encryption>, Option<serde_json::Value>)> { |
There was a problem hiding this comment.
why (Option<T1>,Option<T2>) why not Option<(T1,T2)> if public and private config are coupled ?
There was a problem hiding this comment.
In DB, both are optional, so a case where when one is optional and other is not comes then, we will have to change this everywhere.
crates/router/src/utils/user.rs
Outdated
| public_config, | ||
| } => { | ||
| let private_config_value = serde_json::to_value(private_config.clone()) | ||
| .change_context(UserErrors::AuthConfigParsingError) |
There was a problem hiding this comment.
why is this 400 ? isnt invalid value caught at api level ?
or someone can pass api model validation (serde) but still provide invalid json ?
crates/router/src/utils/user.rs
Outdated
| ), | ||
| )) | ||
| } | ||
| _ => Ok((None, None)), |
There was a problem hiding this comment.
lets match each value here, so that new enum breaks the code at compile time
racnan
reviewed
Jul 1, 2024
crates/router/src/utils/user.rs
Outdated
Comment on lines
254
to
264
| pub fn parse_oidc_public_config( | ||
| public_config: Option<serde_json::Value>, | ||
| ) -> UserResult<Option<user_api::OpenIdConnectPublicConfig>> { | ||
| public_config | ||
| .map(|config| { | ||
| serde_json::from_value::<user_api::OpenIdConnectPublicConfig>(config) | ||
| .change_context(UserErrors::InternalServerError) | ||
| .attach_printable("Unable to parse OpenIdConnectPublicConfig") | ||
| }) | ||
| .transpose() | ||
| } |
There was a problem hiding this comment.
this can be generic instead exclusively for OpenIdConnectPublicConfig.
racnan
approved these changes
Jul 1, 2024
apoorvdixit88
approved these changes
Jul 1, 2024
pixincreate
added a commit
that referenced
this pull request
Jul 2, 2024
…ror-handling-in-cypress * 'main' of github.com:juspay/hyperswitch: fix(auth_methods): Add checks for duplicate `auth_method` in create API (#5161) chore(version): 2024.07.02.0 fix(router): rename the browser name header to `x-browser-name` (#5162) fix(router): mark retry payment as failure if `connector_tokenization` fails (#5114) fix(connector): [Paypal] dispute webhook deserialization failure (#5111) feat(analytics): Add v2 payment analytics (payment-intents analytics) (#5150) feat(globalsearch): Implement tag-based filters in global search (#5151) refactor(connector): Add amount conversion framework to iatapay along with amount conversion code to connector template (#4866) feat(payment_link): add multiple custom css support in business level (#5137) feat(connector): [Bambora Apac] Template for integration (#5062) feat(tls): add support for https in actix web (#5089) chore(ci): fix ci tests failing by removing them (#5167) chore(version): 2024.07.01.0 chore(postman): update Postman collection files ci(postman): log request id for user tests (#5159) chore(euclid_wasm): make field domain optional wasm (#5154)
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Currently create will accept and insert auth methods with same type and name, which shouldn't be possible. This PR fixes that.
Additional Changes
Motivation and Context
Closes #5160.
How did you test it?
If this API is hit with same
auth_typeandnameinpublic_config, then the API will throw the following error.{ "error": { "type": "invalid_request", "message": "User auth method already exists", "code": "UR_43" } }Checklist
cargo +nightly fmt --allcargo clippy