fix(event): Updated the ApiEventMetric

[tanbirali]

Type of Change

• Bugfix

Description

Updated the ApiEventMetric trait to return ApiEventsType::Payment { payment_id : String} variant.
Fixes #5059

Checklist

• I formatted the code cargo +nightly fmt --all
• I reviewed the submitted code

[lsampras]

Hey @tanbirali
you'll need to update the ApiEventMetric trait implementation for PaymentsSessionResponse which is defined here

you can refer to this implementation

hyperswitch/crates/api_models/src/events/payment.rs

Lines 48 to 54 in 86f4060

	impl ApiEventMetric for PaymentsCompleteAuthorizeRequest {
	fn get_api_event_type(&self) -> Option<ApiEventsType> {
	Some(ApiEventsType::Payment {
	payment_id: self.payment_id.clone(),
	})
	}
	}

[tanbirali]

Let me know if I got this right this time

[lsampras]

@tanbirali yup,
can you move it to this file crates/api_models/src/events/payment.rs.
and remove the older implementation here

[tanbirali]

Let me know if I need to do anything else

[lsampras]

Hey @tanbirali, you'll need to remove this line I think since it causes duplicate implementations of this trait

hyperswitch/crates/api_models/src/events.rs

Line 43 in 86f4060

PaymentsSessionResponse,

[lsampras]

Can you also add screenshots for local testing?

you can run the data pipeline and this event should show up in the dashboard events & logs section when you make an sessions api call.

[tanbirali]

Sorry I can't do the local testing right now I had issues setting it up with docker, hyperswitch server was failing, I had a talk with @SanchithHegde about this, if I can I will add a ss of the local test

[lsampras]

@tanbirali Would you be able to fix the CI failures here?

[tanbirali]

Let me give it a try

[tanbirali]

@lsampras All done I guess