-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(core): make save_payment_method as post_update_tracker trait function #4307
Merged
likhinbopanna
merged 60 commits into
main
from
refac/domain_func_for_save_payment_method
Apr 25, 2024
Merged
Refactor(core): make save_payment_method as post_update_tracker trait function #4307
likhinbopanna
merged 60 commits into
main
from
refac/domain_func_for_save_payment_method
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ac/domain_func_for_save_payment_method
…ithub.com/juspay/hyperswitch into refac/domain_func_for_save_payment_method
…ithub.com/juspay/hyperswitch into refac/domain_func_for_save_payment_method
…ithub.com/juspay/hyperswitch into refac/domain_func_for_save_payment_method
Aprabhat19
reviewed
Apr 22, 2024
Aprabhat19
reviewed
Apr 22, 2024
Aprabhat19
previously approved these changes
Apr 22, 2024
…ithub.com/juspay/hyperswitch into refac/domain_func_for_save_payment_method
Aprabhat19
previously approved these changes
Apr 22, 2024
Narayanbhat166
approved these changes
Apr 23, 2024
Aprabhat19
approved these changes
Apr 23, 2024
vspecky
approved these changes
Apr 23, 2024
ShankarSinghC
approved these changes
Apr 24, 2024
pixincreate
added a commit
that referenced
this pull request
Apr 25, 2024
…to-env * 'main' of github.com:juspay/hyperswitch: ci(postman): Fix Adyen postman collection (#4459) docs(cypress): Update Cypress README Documentation (#4380) Refactor(core): make save_payment_method as post_update_tracker trait function (#4307) refactor(connector): pass optional browser_info to stripe for increased trust (#4374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR aims to make the locker call async(again). Moreover the main problem this PR solves is to adding
pm_id
in payment_attempt even in an async locker call. This is achieved by adding up a new function inPostUpdateTracker
trait named assave_pm_and_mandate
.Additional Changes
Motivation and Context
How did you test it?
Curls for the test cases:
Response
Payment Retrieve
Response
Response:
Checklist
cargo +nightly fmt --all
cargo clippy