Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for sending additional metadata in the MessagingInterface #4472

Closed
2 tasks done
lsampras opened this issue Apr 26, 2024 · 8 comments · Fixed by #4875
Closed
2 tasks done

[FEATURE] Add support for sending additional metadata in the MessagingInterface #4472

lsampras opened this issue Apr 26, 2024 · 8 comments · Fixed by #4875
Labels
A-Analytics A-framework Area: Framework C-feature Category: Feature request or enhancement good first issue Good for newcomers

Comments

@lsampras
Copy link
Member

Feature Description

In the current implementation of message interface I can only send a Message & a timestamp associated with the message,
There is no accomodation to send additional metadata about the message which isn't part of the data but could be propogated to the downstream implementations,

These could be used downstream as kafka headers or redis hashes or partition keys.

Possible Implementation

metadata can be a simplistic HashMap<String, String> and can be either accomodated as a new param in the MessagingInterface or a new method on the Message Interface.

The implementers of MessageInterface can handle it as follows

  1. Kafka
    Send the metadata as headers
  2. EventLogger
    Log the metadata as a separate key along with the raw data

Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

None

@lsampras lsampras added A-framework Area: Framework C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet good first issue Good for newcomers A-Analytics labels Apr 26, 2024
@tanbirali
Copy link
Contributor

I am interested in this

@lsampras
Copy link
Member Author

Hey @tanbirali thanks for your interest.
I'll assign this issue, you can ask for clarifications here or reach out on our slack/discord.

@lsampras lsampras removed the S-awaiting-triage Status: New issues that have not been assessed yet label Apr 29, 2024
@tanbirali
Copy link
Contributor

whenever I am running the docker-compose up -d all the services are working but the hyperswitch-hyperswitch-server-1 is exiting everytime starting the container, how can I fix this

@lsampras
Copy link
Member Author

lsampras commented May 2, 2024

Hey @tanbirali ,
Can you share the logs that are emitted on docker failure ?
you can get them via docker compose logs hyperswitch-server..

Also these are the steps for running hyperswitch locally via docker compose you can walk through them again if anything is amiss...

There were some similar issues reported and solved in the discord can check if your issue is present there

@lsampras
Copy link
Member Author

lsampras commented May 8, 2024

Hey @tanbirali ,

Are you still interested/working on this,
Is there any clarification/help you need about this issue.

@tanbirali
Copy link
Contributor

I am working on it, will try to create a PR soon

@tanbirali
Copy link
Contributor

Sorry I am not able to run the project locally, I tried having a convo in the discord community, something or the other is not working for me, sorry for delaying it, I am trying in the mean time if anyone is willing to take this issue, please assign it to the individual

@lsampras
Copy link
Member Author

Hey @tanbirali no worries, I'll keep the issue unassigned for now.

@lsampras lsampras linked a pull request Jun 4, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Analytics A-framework Area: Framework C-feature Category: Feature request or enhancement good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants