Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Role & Delete user added #403

Merged
merged 24 commits into from
Feb 26, 2024
Merged

feat: Update Role & Delete user added #403

merged 24 commits into from
Feb 26, 2024

Conversation

PritishBudhiraja
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Motivation and Context

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@PritishBudhiraja PritishBudhiraja added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 14, 2024
@PritishBudhiraja PritishBudhiraja self-assigned this Feb 14, 2024
@PritishBudhiraja PritishBudhiraja requested a review from a team as a code owner February 14, 2024 12:34
@PritishBudhiraja PritishBudhiraja linked an issue Feb 14, 2024 that may be closed by this pull request
feat: Incorporate update role flow #369
Closed
@PritishBudhiraja PritishBudhiraja added S-in-progress Status: Implementation is underway and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 14, 2024
@PritishBudhiraja PritishBudhiraja added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-in-progress Status: Implementation is underway labels Feb 17, 2024
JeevaRamu0104
JeevaRamu0104 reviewed Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@JeevaRamu0104 JeevaRamu0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add modal for the delete user flow.try adding some cypress test

@JeevaRamu0104 JeevaRamu0104 added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 20, 2024
@PritishBudhiraja
Copy link
Contributor Author

Add modal for the delete user flow.try adding some cypress test

Addressed.

@PritishBudhiraja PritishBudhiraja added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Feb 20, 2024
@PritishBudhiraja PritishBudhiraja added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit e79e5ea Feb 26, 2024
5 checks passed
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 26, 2024
@PritishBudhiraja PritishBudhiraja deleted the update-delete-user branch March 28, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@Riddhiagrawal001 Riddhiagrawal001 Riddhiagrawal001 approved these changes

Assignees

@PritishBudhiraja PritishBudhiraja

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Incorporate update role flow
3 participants
@PritishBudhiraja @Riddhiagrawal001 @JeevaRamu0104