Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: addition of pm authentication processor new flow #1125

Merged
merged 4 commits into from
Aug 9, 2024
Merged

feat: addition of pm authentication processor new flow #1125

merged 4 commits into from
Aug 9, 2024

Conversation

gitanjli525
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

PM Authentication Processor new flow

Motivation and Context

How did you test it?

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 self-assigned this Aug 8, 2024
@gitanjli525 gitanjli525 requested a review from a team as a code owner August 8, 2024 08:06
@gitanjli525 gitanjli525 linked an issue Aug 8, 2024 that may be closed by this pull request
[FEATURE] Plaid Open Banking Integration #1092
Closed
5 tasks
JeevaRamu0104
JeevaRamu0104 previously approved these changes Aug 8, 2024
View reviewed changes
PritishBudhiraja
PritishBudhiraja requested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like why we are following backend naming convention throughout codebase. In FE, JS standard is camelCase try to change this to that not snake_case

@gitanjli525
Copy link
Contributor Author

Like why we are following backend naming convention throughout codebase. In FE, JS standard is camelCase try to change this to that not snake_case

We can make that change in a separate PR, here it is done so as to maintain consistency with existing code itself.

@PritishBudhiraja PritishBudhiraja added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit d18b4d1 Aug 9, 2024
5 of 6 checks passed
@PritishBudhiraja PritishBudhiraja deleted the pm-auth-processor-flow branch August 9, 2024 08:52
@github-actions github-actions bot added the Closed Applied to issues or pull requests that have been successfully resolved or completed label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagarnaikjuspay sagarnaikjuspay sagarnaikjuspay approved these changes

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@Riddhiagrawal001 Riddhiagrawal001 Awaiting requested review from Riddhiagrawal001

@JeevaRamu0104 JeevaRamu0104 Awaiting requested review from JeevaRamu0104

Assignees

@gitanjli525 gitanjli525

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Plaid Open Banking Integration
5 participants
@gitanjli525 @Riddhiagrawal001 @PritishBudhiraja @JeevaRamu0104 @sagarnaikjuspay