chore: make email with password login #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagarnaikjuspay
added
S-waiting-on-review
PritishBudhiraja
previously approved these changes
Aug 5, 2024
…ontrol-center into sign-in-flow-change
PritishBudhiraja
approved these changes
Aug 21, 2024
JeevaRamu0104
approved these changes
Aug 21, 2024
github-actions
bot
added
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Made a sign in with email and password has a default flow even is the magic link is enabled
Motivation and Context
How did you test it?
open a dashboard and if signed in logout, the dashboard should take u to sign in with password page, even if u enable magic link feature flag, still it should take u to sign-in with password page only
Where to test it?
Checklist
npm run re:build