Fix the opening of notebooks in a new tab when using the JupyterLite directive
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agriyakhetarpal
force-pushed
the
fix/new-tab-for-jupyterlite-directive
branch
from
a831b91 to
4bb0660
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The JupyterLite directive allows for a
:new_tab:configuration option that was established in #165, which does what it says: provide a button to open a notebook file passed to it with the JupyterLite interface in a new tab. This PR adds theindex.htmlprefix to the URL similar to #182 to fix the loading of the notebooks – without this, we arrive at the file server and JupyterLite does not load until we browse into thedocs/_contents/directory ourselves.Changes made
index.htmlprefix has been added to the JupyterLite app URLs for all directives/apps. This prefix previously existed only for theTryExamplesdirective.Additional context
I came across this when testing the SciPy docs builds locally when attempting a fix for #191 while working on the
scipy.statsnotebooks, which did not load properly in new tabs until this change was made.cc: @melissawm