Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit DataGrid public API in preparation for 0.x => 2.0 #458

Merged
merged 18 commits into from
Nov 22, 2022
Merged

Audit DataGrid public API in preparation for 0.x => 2.0 #458

merged 18 commits into from
Nov 22, 2022

Conversation

afshin
Copy link
Member

@afshin afshin commented Nov 1, 2022 •
edited
Loading

In this PR:

  • All public package versions are set to 2.0.0-alpha.6
  • Moves the standalone Notification class for DataGrid instances that use CellEditor into the latter's namespace: CellEditor.Notification

@afshin afshin added the maintenance Dependencies, build, technical debt, etc. label Nov 1, 2022
@afshin afshin added this to the Lumino 2 milestone Nov 1, 2022
@afshin afshin self-assigned this Nov 1, 2022
@blink1073
Copy link
Contributor

I believe from a releaser standpoint we need to set version-cmd here to npm run update:versions and update the release instructions.

@blink1073
Copy link
Contributor

Need to pass a -y flag I think: ? Are you sure you want to create these versions? (ynH)

@blink1073
Copy link
Contributor

It is --yes

@fcollonval
Copy link
Member

I'm not convinced we should go that road. It was not needed earlier and we also decide it was not needed for JupyterLab (although dependency cycles are still to be removed).

I'm in favor to bump all packages for v2. But going forward in v2 branch I don't see the benefit to use fixed version as most of the time is will bumped packages for no reasons.

@afshin afshin changed the title Set package versions to fixed Set all public packages to 2.0 Nov 4, 2022
@afshin afshin marked this pull request as ready for review November 7, 2022 12:11
fcollonval
fcollonval reviewed Nov 9, 2022
View reviewed changes
RELEASE.md Outdated Show resolved Hide resolved
.github/workflows/tests.yml Show resolved Hide resolved
@vidartf
Copy link
Member

vidartf commented Nov 9, 2022

The diff now contains a lot of changes to datagrid, which doesn't seem related to the title of this PR?

@afshin
Copy link
Member Author

afshin commented Nov 10, 2022

The diff now contains a lot of changes to datagrid, which doesn't seem related to the title of this PR?

Yeah, I should make two PRs, probably.

Basically the name Notification is a DOM concept window.Notification so before making DataGrid a post-1.0 version, that part of the API needs updating. This was meant to be an all-in-one version PR for all the packages, but since @lumino/datagrid requires some changes, maybe I should take all the version stuff out of this PR and just use this branch to update DataGrid.

@afshin afshin changed the title Set all public packages to 2.0 Audit DataGrid public API in preparation for 0.x => 2.0 Nov 18, 2022
@afshin
Copy link
Member Author

afshin commented Nov 18, 2022

cc: @martinRenou @ibdafna

martinRenou
martinRenou approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@afshin afshin merged commit 750fea2 into jupyterlab:main Nov 22, 2022
krassowski added a commit to krassowski/jupyterlab that referenced this pull request Jan 21, 2023
@krassowski
Re-align @lumino/datagrid version
0fe7ef5 
This is because initially it was bumped to 1.0-alpha but then
the decision changed to move directly to 2.0 in:
jupyterlab/lumino#458
@krassowski krassowski mentioned this pull request Jan 21, 2023
Merged
2 tasks
krassowski added a commit to krassowski/jupyterlab that referenced this pull request Jan 21, 2023
@krassowski
Re-align @lumino/datagrid version
2681796 
This is because initially it was bumped to 1.0-alpha but then
the decision changed to move directly to 2.0 in:
jupyterlab/lumino#458
fcollonval pushed a commit to krassowski/jupyterlab that referenced this pull request Jan 25, 2023
@krassowski @fcollonval
Re-align @lumino/datagrid version
375bcf4 
This is because initially it was bumped to 1.0-alpha but then
the decision changed to move directly to 2.0 in:
jupyterlab/lumino#458
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval left review comments

@martinRenou martinRenou martinRenou approved these changes

Assignees

@afshin afshin

Labels
maintenance Dependencies, build, technical debt, etc.
Projects
None yet
Milestone
Lumino 2
Development

Successfully merging this pull request may close these issues.
5 participants
@afshin @blink1073 @fcollonval @vidartf @martinRenou