Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for list of keystrokes #433

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Oct 7, 2022

Reference

Xref: jupyterlab/jupyterlab#13180

Code changes

Support passing a list of keys to Command.formatKeystroke to get a comma-separated representation as the one used in menus.

@fcollonval fcollonval added the enhancement New feature or request label Oct 7, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcollonval fcollonval merged commit b5bf5ea into jupyterlab:main Oct 10, 2022
@fcollonval fcollonval deleted the enh/format-key-list branch October 10, 2022 08:02
@fcollonval
Copy link
Member Author

@meeseeksdev please backport to 1.x

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 10, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 b5bf5eacdb0fa516874da3cb8660ae3c7bc1a3da
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #433: Add support for list of keystrokes'
  1. Push to a named branch:
git push YOURFORK 1.x:auto-backport-of-pr-433-on-1.x
  1. Create a PR against branch 1.x, I would have named this PR:

"Backport PR #433 on branch 1.x (Add support for list of keystrokes)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants