Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labelledby to support multiple elements on page #407

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

fcollonval
Copy link
Member

The title id for accordion panel and tabbar were not unique if multiple widgets were displayed on the same page. This fixes it.

@fcollonval fcollonval added accessibility Addresses accessibility needs bug Something isn't working labels Sep 14, 2022
@fcollonval fcollonval added this to the 1.x milestone Sep 14, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fcollonval fcollonval merged commit 942ab86 into jupyterlab:main Sep 14, 2022
@fcollonval fcollonval deleted the fix/aria-labelledby branch September 14, 2022 11:55
@fcollonval
Copy link
Member Author

@meeseeksdev please backport to 1.x

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 14, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 942ab864bcf89dc88246b83c6fb372fa9e05a079
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #407: Fix labelledby to support multiple elements on page'
  1. Push to a named branch:
git push YOURFORK 1.x:auto-backport-of-pr-407-on-1.x
  1. Create a PR against branch 1.x, I would have named this PR:

"Backport PR #407 on branch 1.x (Fix labelledby to support multiple elements on page)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

fcollonval added a commit to fcollonval/lumino that referenced this pull request Sep 14, 2022
afshin added a commit that referenced this pull request Sep 14, 2022
Backport PR #407 on branch 1.x (Fix labelledby to support multiple elements on page)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Addresses accessibility needs bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants