Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataGrid mouse handler: Expose pressData for subclasses #146

Merged
merged 2 commits into from
Jan 5, 2021
Merged

DataGrid mouse handler: Expose pressData for subclasses #146

merged 2 commits into from
Jan 5, 2021

Conversation

martinRenou
Copy link
Member

This is useful for subclasses to know what is currently happening

@martinRenou
Copy link
Member Author

The CI failure looks unrelated, it might pass if launched again.

blink1073
blink1073 approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Just one nit

@martinRenou
Copy link
Member Author

Thanks for the review!

@blink1073 blink1073 merged commit 20152f9 into jupyterlab:master Jan 5, 2021
@martinRenou martinRenou deleted the pressdata branch January 5, 2021 18:49
@blink1073
Copy link
Contributor

@lumino/datagrid: 0.17.0 => 0.18.0

@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @blink1073