-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the plugins handling out of the Application
#697
Comments
Thanks @fcollonval for opening the issue 👍 Linking to #586 as this may also help with this use case. |
@fcollonval just checking if you had plans to look into this yourself, or if other contributors could also start looking into it? |
I started a branch. I hope to get a PR next week. Is it too late? |
OK great, thanks for starting this! I just wanted to double check what the status on this was, to avoid double work in case someone would be interested in looking into this. |
Problem
The plugins are handled directly within the
Application
. This prevents the usage of plugins to initialize application attribute. The symptomatic case is the need to customize the service manager in JupyterLab.Xref:
ServiceManager
into multiple plugins jupyterlab#15329Proposed Solution
Extracting the plugin resolver logic in its own class (because why should such great feat be hard linked to the Application). Once we get that the logic in index.js will be:
Additional context
The text was updated successfully, but these errors were encountered: