Fix GlobalCompositeOperation error in data grid package

[SnarkBoojum]

Compiling datadrid with a recent typescript leads to:

src/graphicscontext.ts(243,7): error TS2322: Type 'string' is not assignable to type 'GlobalCompositeOperation'.

So I guess there's again a stricter typing in typescript breaking parts of lumino.

By recent version of typescript, I mean 4.6.3.

[SnarkBoojum]

I dug a little, and I think the reason is that they tightened things in typescript so the type wouldn't be the same depending on the given string -- and for an unknown string, that means an error : see here

[SnarkBoojum]

This looks like a trivial fix:

-  get globalCompositeOperation(): string {
+  get globalCompositeOperation(): GlobalCompositeOperation {
     return this._context.globalCompositeOperation;
   }
 
-  set globalCompositeOperation(value: string) {
+  set globalCompositeOperation(value: GlobalCompositeOperation) {

[vidartf]

Did you want to open a PR with your proposed changes (so credit can be attributed in commit log etc), or are you hoping someone else can code this up?

[vidartf]

PS: It is also worth noting what the proposed change would do to the minimally required TS version.

[SnarkBoojum]

I don't know how that changes the minimally required TS version.

Last time an upstream wanted a PR for a trivial fix (so credit can be attributed in commit log etc), the commit still looks like it comes from upstream, see, so I'm not sure I'll bother this time.

[blink1073]

I see your commit in the history: graph-algorithms/edge-addition-planarity-suite@c03109f