Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the bubbling_keydown page config option? #15158

Closed
jtpio opened this issue Sep 26, 2023 · 3 comments
Closed

Document the bubbling_keydown page config option? #15158

jtpio opened this issue Sep 26, 2023 · 3 comments
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Sep 26, 2023

Follow-up to #15142

#15142 (comment) raises the question of whether the new bubbling_keydown page config option should be documented.

#15142 (comment) says it's not clear yet, but could be decided before releasing 4.1 final.

So opening this issue to keep track of it for 4.1.

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Sep 26, 2023
@jtpio jtpio added this to the 4.1.0 milestone Sep 26, 2023
@krassowski krassowski removed the status:Needs Triage Applied to new issues that need triage label Sep 26, 2023
@brichet
Copy link
Contributor

brichet commented Nov 14, 2023

The bubbling_keydown page config option has been removed in #14115, in this commit 5c6c7d7.

It was an experimental config not needed anymore, and which can bring instability.

@fcollonval
Copy link
Member

Closing as it was removed

Xref #15405 (comment)

@fcollonval fcollonval closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2023
@jtpio
Copy link
Member Author

jtpio commented Nov 14, 2023

ok thanks for the update 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants