You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Allow retry timeout configurability for acquiring the index.lock.
Suspend UI interactions until pending command complete (e.g., a modal with a spinner). I believe this should be straightforward, as we just need to enable a UI element until receiving an HTTP response.
The need for the latter is to prevent/dissuade the user from closing the JupyterLab server before pending commands have had a chance to complete (e.g., before an index.lock file is removed and git add && git commit run, thus potentially leading to the discarding of user changes).
I'm not sure if any UX discussions have happened around this, but the JupyterLab Status Bar is a candidate for to notify the user that an async background process is running, without having a dialog blocking their view.
(JFYI the Status Bar was not present in JL core while many of these Git actions were implemented)
Thanks for the suggestion. I'd still lean toward using a backdrop or other UI element to prevent further user action. The main impetus for this is to guard against the "race condition" of a user ending the server process before commands have finished executing. A status bar indicator is unlikely to dissuade users from prematurely doing so.
This is a follow-up of #564.
Proposal:
The need for the latter is to prevent/dissuade the user from closing the JupyterLab server before pending commands have had a chance to complete (e.g., before an
index.lock
file is removed andgit add && git commit
run, thus potentially leading to the discarding of user changes).Originally posted by @kgryte in #564 (comment)
The text was updated successfully, but these errors were encountered: