Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Detailed message" is an empty popup after pushing changes #1293

Closed
krassowski opened this issue Nov 10, 2023 · 0 comments · Fixed by #1299
Closed

"Detailed message" is an empty popup after pushing changes #1293

krassowski opened this issue Nov 10, 2023 · 0 comments · Fixed by #1299
Labels
bug

Comments

@krassowski
Copy link
Member

krassowski commented Nov 10, 2023 •
edited
Loading

Description

"Detailed message" is an empty popup after pushing changes

Reproduce

  1. Commit changes
  2. Push changes
  3. Click on red "details" button in toast notification
    image
  4. See empty popup:
    image

image

Expected behavior

The pop-up is not empty, or the button is not shown in the first place if there is nothing to show.

Context

50.0.0rc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't display details button if message is empty fcollonval/jupyterlab-git
1 participant
@krassowski